Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDR correction #2

Open
julien-roux opened this issue Dec 8, 2016 · 0 comments
Open

FDR correction #2

julien-roux opened this issue Dec 8, 2016 · 0 comments

Comments

@julien-roux
Copy link
Contributor

julien-roux commented Dec 8, 2016

(Not really an issue, but more a discussion post):

It is not clear if correcting the p-values to get a FDR is valid: the different tests we perform are not independent because of propagation of data through the ontology. The decorrelation methods of topGO make them even less independent (see section in topGO manual). For now I don't see any solution to this problem, and my feeling is that the FDR is conservative in this setting, so this is not a critical problem (but it is just a feeling I might be wrong).

Another problem is that depending on the tissues, the power of the test changes greatly. The more genes mapped to a term, the more power has our test. This can also affect our FDR correction. An idea is to incorporate this is FDR calculations, as done in the IHW package: http://bioconductor.org/packages/devel/bioc/vignettes/IHW/inst/doc/introduction_to_ihw.html. This is something we could easily add to BgeeDB! The covariate vector being the number of genes mapped to each term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant