Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a random verse on home view at application launch #16

Merged
merged 7 commits into from Aug 11, 2022

Conversation

Correct-Syntax
Copy link
Member

Implementation of BibleNotify/BibleNotify#9 for desktop.

Notes

  • Let me know if you think the verse text is too large
  • Component.onCompleted seems to be working, just not Loader.printHello so I removed your TODO (@iwoithe)

Copy link
Member

@iwoithe iwoithe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. The proposed changes work as intended. Looking forward to having this merged. 🙂

src/assets/assets.py Outdated Show resolved Hide resolved
src/biblenotify/ui/BibleNotify/Views/HomeView.qml Outdated Show resolved Hide resolved
src/biblenotify/ui/main.qml Show resolved Hide resolved
src/biblenotify/ui/BibleNotify/Views/HomeView.qml Outdated Show resolved Hide resolved
src/biblenotify/ui/main.qml Outdated Show resolved Hide resolved
src/biblenotify/ui/main.qml Outdated Show resolved Hide resolved
src/biblenotify/ui/BibleNotify/Views/HomeView.qml Outdated Show resolved Hide resolved
src/biblenotify/ui/BibleNotify/Views/HomeView.qml Outdated Show resolved Hide resolved
@Correct-Syntax Correct-Syntax merged commit 77707a9 into master Aug 11, 2022
@Correct-Syntax Correct-Syntax deleted the home-verse branch August 11, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants