Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TomapProjector attribution match options #45

Open
rbossy opened this issue Dec 7, 2017 · 1 comment
Open

TomapProjector attribution match options #45

rbossy opened this issue Dec 7, 2017 · 1 comment

Comments

@rbossy
Copy link
Member

rbossy commented Dec 7, 2017

  • lemmaKeys, caseInsensitive and ignoreDiacritics control both projection and attribution. Make separate options for attribution

  • add option to match surface form OR lemma

@rbossy rbossy self-assigned this Feb 1, 2018
@rbossy
Copy link
Member Author

rbossy commented Feb 12, 2018

@ldeleger

We can implement this, however the classifier saved by ToMapTrain must be aware of these options.

That means that a classifier file will only be able to function for the specific matching options it was created with. Would that be okay?

This also means that there might be different matching and projection options in ToMapProjector. We can either:

  • override the projector options (and issue a warning at runtime)
  • let the user shoot their feet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant