Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility on extension with Improved 42 Intra fails #2

Open
Mariomm-marti opened this issue Aug 24, 2022 · 2 comments
Open

Compatibility on extension with Improved 42 Intra fails #2

Mariomm-marti opened this issue Aug 24, 2022 · 2 comments
Assignees
Labels
bug Something isn't working medium priority The bug affects the functionality partially without breaking, without major changes in data

Comments

@Mariomm-marti
Copy link
Collaborator

Issue

Improved 42 Intra fails from time to time (like in #1 used to happen).
When this happens and. you have both extensions installed, white-nova-extension works. However, if Improved 42 Intra works ours won't display the correct number of remaining days.
image

Proposed solution

Detect whether the HTML rendered is vanilla or modified. If it has been modified, don't append the number of remaining days.

Details

Extension release v2.0.1
Google Chrome Version 98.0.4758.80
MacOS Mojave 10.14.5
https://profile.intra.42.fr/

@Mariomm-marti Mariomm-marti added the bug Something isn't working label Aug 24, 2022
@Mariomm-marti Mariomm-marti added the medium priority The bug affects the functionality partially without breaking, without major changes in data label Aug 26, 2022
@FreekBes
Copy link

As the creator of the Improved Intra extension, I'd be happy to help resolve this issue and make sure both extensions are compatible with each other. Especially since they both have quite the user base. If you need anything from my side, do not hesitate to reach out.

@Bidijoe45
Copy link
Owner

@FreekBes Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority The bug affects the functionality partially without breaking, without major changes in data
Projects
None yet
Development

No branches or pull requests

3 participants