Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizon.height is broken #2

Closed
ghost opened this issue Nov 22, 2018 · 1 comment
Closed

horizon.height is broken #2

ghost opened this issue Nov 22, 2018 · 1 comment
Assignees
@BigFatDog
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Nov 22, 2018

Expected Behavior

horizon.height([pixels]) should set the horizon height when passed a value.

Current Behavior

The height remains 30px.

Steps to Reproduce

  1. Open one of the demos of the repository, like stock.html or simple.html
  2. Change the height of a horizon chart:
    context.horizon(d3.selectAll(".horizon")).height(120)
@BigFatDog BigFatDog added the bug Something isn't working label Nov 23, 2018
@BigFatDog BigFatDog self-assigned this Nov 23, 2018
@BigFatDog BigFatDog mentioned this issue Nov 27, 2018
Merged
@BigFatDog
Copy link
Owner

Version 1.1.0 has been released to fix this bug.

@ghost ghost closed this as completed Nov 29, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BigFatDog BigFatDog

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BigFatDog