Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes types are not correctly detected if null present #118

Open
prithvikannan opened this issue Jan 31, 2023 · 0 comments
Open

Axes types are not correctly detected if null present #118

prithvikannan opened this issue Jan 31, 2023 · 0 comments

Comments

@prithvikannan
Copy link

prithvikannan commented Jan 31, 2023

Nulls are not properly handled in the first row of the dataset. However, if null exists in a later row, then the chart will render properly.

A current workaround to this problem is to cast null values as strings, but that creates an additional challenge of columns being inferred as "string" type even if they are numeric.

The source of this issue is here
https://github.com/BigFatDog/parcoords-es/blob/master/src/api/detectDimensionTypes.js#L3-L10

I have written this PR with a proposed fix #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant