Improve typings by allowing JSONSchema6 objects #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 95.238% when pulling 5a6fbedc3278ce7e71357cd7891460dc17b04c74 on krenor:improve-typings into cc40cb5 on BigstickCarpet:master. |
|
@BigstickCarpet This seems like an Issue with Travis setup regarding yarn.. should I remove the |
|
Hi @krenor. Thanks for the PR. Sorry for the delayed response. Yes, please remove the Lemme know once that's done and I'll happily merge this PR. Thanks for your work!!! 👍 |
krenor
force-pushed
the
improve-typings
branch
from
5a6fbed
to
3693ea4
Compare
|
This PR has been released in v4.1.1 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found no restriction which only applies to
JSONSchema4objects.Also
@types/nodehave been added to dev-dependencies sinceBuffercan't be found without them.