Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Migrate APIs.guru related URLs #45

Merged
merged 4 commits into from Jun 14, 2016
Merged

[Do not merge] Migrate APIs.guru related URLs #45

merged 4 commits into from Jun 14, 2016

Conversation

IvanGoncharov
Copy link
Contributor

Hi @BigstickCarpet,

We are migrating our URLs to APIs.guru domain, here is more details:
APIs-guru/openapi-directory#85
Plus I add Tested on APIs.guru badge, hope you will like it 馃槃
Tested on APIs.guru

@coveralls
Copy link

coveralls commented Jun 9, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling b14e897 on APIs-guru:master into af2b284 on BigstickCarpet:master.

@JamesMessinger
Copy link
Member

@IvanGoncharov - Thanks for the excellent PR, as always. Apis.guru is looking good! You've done a lot of excellent work there! Also, I love the badge that you added.

Some of the Travis CI build are failing, and I think it has to do with the http-to-https redirect that occurs when visiting http://api.apis.guru/v2/list.json. Can you try modifying the URL to be https (to avoid the redirect) and see if that fixes the builds?

@IvanGoncharov
Copy link
Contributor Author

@BigstickCarpet We removed http to https redirection.
But I think https is always better so I switched URL to it.

Thanks for the excellent PR, as always. Apis.guru is looking good! You've done a lot of excellent work there! Also, I love the badge that you added.

Thank you, you was the first person who used APIs.guru.
And it was even before I implement API v1: #4 (comment)

P.S. Still missing Twitter and in general have < 700 APIs. But I think we moving in right direction :)

@coveralls
Copy link

coveralls commented Jun 10, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling 286b79d on APIs-guru:master into af2b284 on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling 1be56c9 on APIs-guru:master into af2b284 on BigstickCarpet:master.

@IvanGoncharov IvanGoncharov changed the title Migrate APIs.guru related URLs [Do not merge]Migrate APIs.guru related URLs Jun 13, 2016
@IvanGoncharov IvanGoncharov changed the title [Do not merge]Migrate APIs.guru related URLs [Do not merge] Migrate APIs.guru related URLs Jun 13, 2016
@IvanGoncharov
Copy link
Contributor Author

@BigstickCarpet It looks like all problem is related to CloudFlare.
I can't disable their DDoS prevention which blocks PhantomJS.

I want to try S3 as a storage.
So I manually put API folder on S3 and will change API root in this PR.

@JamesMessinger
Copy link
Member

Ok, cool. I was wondering why the tests were failing, but haven't had time to look into it

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling f5a9a9c on APIs-guru:master into af2b284 on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling 984abbe on APIs-guru:master into af2b284 on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling acda65a on APIs-guru:master into af2b284 on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling b3f0b51 on APIs-guru:master into af2b284 on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling c1251d9 on APIs-guru:master into af2b284 on BigstickCarpet:master.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 98.438% when pulling 6c8d738 on APIs-guru:master into af2b284 on BigstickCarpet:master.

@JamesMessinger JamesMessinger merged commit 3fbbb0f into APIDevTools:master Jun 14, 2016
@JamesMessinger
Copy link
Member

Thanks again, @IvanGoncharov !!!

@IvanGoncharov
Copy link
Contributor Author

@BigstickCarpet https://s3.amazonaws.com/api.apis.guru just tests URL. I plan to use S3+CloudFront as the backend for api.apis.guru. But before that, I need to setup CI deploy + CloudFront + DNS.

So I can create new PR and continue testing or you can revert this PR.
Both scenarious works for me.

@JamesMessinger
Copy link
Member

Oh. Sorry. I saw that all the tests finally passed on Travis CI, so I thought you were done with this PR. That's why I merged it.

Can you create a new PR to continue your testing? That'll be easier (for me :) ) than reverting this PR.

@IvanGoncharov
Copy link
Contributor Author

@BigstickCarpet Cool, I will create new PR. Your test suite is ideal for load testing since it's 5 tests in parallel doing async HTTP requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants