Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans on supporting null safety? #137

Closed
DanMossa opened this issue Feb 18, 2021 · 11 comments
Closed

Plans on supporting null safety? #137

DanMossa opened this issue Feb 18, 2021 · 11 comments

Comments

@DanMossa
Copy link

Hello!

I was wondering if there were any plans to support null safety?

Thanks!

@rc8marcelo
Copy link

Flutter 2.0 just released and null safety has been made stable. Is there any update if the package will be supporting null safety?

@pacholoamit
Copy link

Hello yeah I'm also interested to inquire if this would support null safety.

@DanMossa
Copy link
Author

DanMossa commented Mar 7, 2021

I'll make a PR to support null-safety later today!

@KgotsoK
Copy link

KgotsoK commented Mar 8, 2021

Thank you @DanMossa!!

@DanMossa
Copy link
Author

DanMossa commented Mar 8, 2021

Quick PR in #144
I'm using my repo/branch in the meantime like this in pubspec.yaml

  persistent_bottom_nav_bar:
    git: git@github.com:DanMossa/PersistentBottomNavBar.git

Until this gets merged into the official repo.

@RealBug
Copy link

RealBug commented Mar 9, 2021

Quick PR in #144
I'm using my repo/branch in the meantime like this in pubspec.yaml

  persistent_bottom_nav_bar:
    git: git@github.com:DanMossa/PersistentBottomNavBar.git

Until this gets merged into the official repo.

Thanks for the work, it's cool! However, I don't think it's a good idea this merge request because it's more than "Quick and dirty", it could generate crashes with the "!".

@DanMossa
Copy link
Author

DanMossa commented Mar 9, 2021

@RealBug
Yeah, that's a fair point. I have been using it on my production app with no issues though.
I actually think this repo may not be managed at this point seeing as how there's an open PR from November

@KgotsoK
Copy link

KgotsoK commented Mar 16, 2021

Yeah. I have been checking here often to see if @BilalShahid13 would comment.

@KgotsoK
Copy link

KgotsoK commented Mar 16, 2021

Currently using @DanMossa's version. I really hope we can get this sorted

  persistent_bottom_nav_bar:
    git: git@github.com:DanMossa/PersistentBottomNavBar.git

@BilalShahid13
Copy link
Owner

I'm sorry to keep you all waiting. I have been really busy with my office work and in pandemic conditions it was next to impossible to find some spare time. I have committed to deliver updates before but failed to do so unfortunately. But I am glad to tell you all that most of the nuisances have been resolved and I will be working at full steam moving forward hopefully. You can anticipate a big release in the coming days :) Thank you for your patience.

@BilalShahid13
Copy link
Owner

Null safety is now supported! Please check the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants