Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls surface.set_tiles with an empty array of tiles #35

Open
SGZ-Creations opened this issue Jun 1, 2023 · 5 comments
Open

Calls surface.set_tiles with an empty array of tiles #35

SGZ-Creations opened this issue Jun 1, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@SGZ-Creations
Copy link

The mod The Ruins Mod (1.1.6) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event AbandonedRuins::on_tick (ID 0)
The mod NiceFill (0.1.20) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event nicefill-scriptfix::script_raised_set_tiles (ID 83)
__nicefill-scriptfix__/control.lua:370: attempt to index field '?' (a nil value)
stack traceback:
	__nicefill-scriptfix__/control.lua:370: in function <__nicefill-scriptfix__/control.lua:366>
stack traceback:
	[C]: in function 'set_tiles'
	__AbandonedRuins__/spawning.lua:117: in function 'spawn_tiles'
	__AbandonedRuins__/spawning.lua:173: in function 'spawn_ruin'
	__AbandonedRuins__/spawning.lua:184: in function 'spawn_random_ruin'
	__AbandonedRuins__/control.lua:58: in function <__AbandonedRuins__/control.lua:53>

https://mods.factorio.com/mod/nicefill-scriptfix

@SGZ-Creations
Copy link
Author

@Bilka2
Copy link
Owner

Bilka2 commented Jun 5, 2023

Looks AbandonedRuins is doing a surface.set_tiles with an empty tiles array and the nicefill-scriptfix mod doesn't handle the resulting event having an empty tiles array. I'd consider it a bug on both sides - this mod for doing a useless call, the other mod for not handling a valid event.

@Bilka2 Bilka2 changed the title Crash with NiceFill Calls script.set_tiles with an empty array of tiles Jun 5, 2023
@Bilka2 Bilka2 added the bug Something isn't working label Jun 5, 2023
@SGZ-Creations
Copy link
Author

well it's reported on both sides too as the link tells

@Bilka2
Copy link
Owner

Bilka2 commented Jun 5, 2023

Yeah, just sharing the results of my investigation.

Note for self: The array is empty because none of the tiles in the ruin exist as prototypes, due to SE or Alien Biomes or whatever.

@Bilka2 Bilka2 changed the title Calls script.set_tiles with an empty array of tiles Calls surface.set_tiles with an empty array of tiles Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants