-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix click handling #117
Comments
|
I see, in this case we should discuss upstream (and maybe @wmcbrine is also willing to take on this task) about your "stack" mouse events suggestion (which seem to leaves the combination with the keyboard out - those events would need to be gathered separately and added to the final result; like [ALT]+[SHIFT]+[double click] along with [ALT]+[SHIFT]+[press]); and I'd highly suggest to use
The good thing is that PDCurses is not about windows but about curses. Therefore the goal for all ports (including wincon/wingui) should be to be identical. |
OK, couldn't resist a little tinkering. WinGUI now has the logic in it for "proper" mouse click handling abstracted. At some point, it can be pulled out and used for other platforms; right now, I figure I've provided William enough to think about for upstream merging. |
Sounds good.
As mentioned before the most important thing is not a Windows convention but a convention that is concise between the ports and following curses convention.
Can you please create an issue upstream about which things you've changed (referencing the commits for easier merge) and which open points (general abstraction I think) are there?
Just to ensure this doesn't get lost...
|
The release notes say:
Sounds good |
@Bill-Gray What is the current state of the click handling between the ports now? |
Not very good, I'm afraid. Only VT and WinGUI have triple clicks... and I just gave it a try with (Thus far, 4.2.1 will add the |
Friendly ping on the status. |
I'm not sure if this is the correct place to post about the issues I am having with detecting clicks on the GL build. I am seeing that no matter what mouseinterval I set, I always get a mouse press event followed by a mouse release event, but never a mouse click event (let alone double or triple click). It would appear that I need to set mouseinterval(0) and detect clicks on my own if I want consistent behavior between the wincon and gl builds of my application. Let me know if this should be a separate bug report. I see this discussion is more about handling of double and triple clicks, so the issue I am seeing is closely related, but not necessarily the same issue. |
Yup, it's a separate issue. (One I'm not seeing, which may be yet another SDL 2.x.x variation; there seem to be a lot of them. Your fix looks good, though.) |
Quoting from the temporal TODO;
perfectly fine, with handling the click resolution by
mouseinterval()
- as this is explicit what is documented.I assume wincon does the same.
That's a real bad bug for me without any exception - no one should handle this in the application code - that's what
mouseinterval()
should handling and I can't think of a reason that the wingui port cannot handle this.That's slightly better, but still bad, if
mouseinterval()
is ignored (which is not what the documentation in mouse.c says) then please create a bug report upstream.The text was updated successfully, but these errors were encountered: