integrated terminal colors problem after 2.12.7

[LukasPolak]

After update to version 2.12.7 I have a problem with integrated terminal colors

[imfing]

@LukasPolak
Same problem.
I checked, this only occurs in powershell that the color resembles the background.

Hope the author solve this. It's too hard to distinguish what I have input.

(There is a -v 😂

[Binaryify]

I just publish a new version, please update and check if it have been fix

[Binaryify]

@LukasPolak @mtobeiyf

[imfing]

@Binaryify Much better. Thanks for the quick fix.

[PixelT]

For me it's still broken, I had white font color, now I have as -v on image above...

[Binaryify]

@PixelT could you provide some screenshot?

[PixelT]

@Binaryify

Earlier I had white text color on this blue & green elements

[Binaryify]

@PixelT so you want it be pure white right?

[LukasPolak]

for me is fixed now! thanks for the quick fix! appreciate it

[Or3stis]

This issue may depend on the local configuration of your terminal colors. If your default terminal colors are light theme based (white background), then some colors will not be displayed currently using this theme (dark background) in vscode.

@PixelT, @LukasPolak can you share your terminal color configuration of your .bash_profile so we can test this?

It seems odd that the terminal.ansiBrightBlack needs to use a light color value to be legible in your settings.

[Binaryify]

@Or3stis
maybe it should be more light

[svipas]

I suggest returning back as it was. Just delete the terminal coloring and keep to default as it was before.

[Or3stis]

@svipben why?

With the updated colors, the terminal looks more consistent with the rest of the color theme.

I would prefer to investigate the issue. If it affects only all PowerShell users or a portion of PowerShell there might be an issue with their configuration. I have been using that color scheme for a couple of weeks before I made the PR without any issue.

As I said, it seems odd that the terminal.ansiBrightBlack color needs a white color value to display text.

[svipas]

I never had such issues with default terminal coloring which looked perfect.

For me the "terminal.ansiWhite" is bad.

[Or3stis]

I see what you mean.

It is best to revert the changes then.

I will keep the updated colors in my settings to test them further.

[svipas]

@Or3stis I will create PR which removes terminal coloring and keeps it as it was by default. Anyways thanks for contributing for this theme, try to test all possible cases and when you think it will be ready you can create new PR which can be reviewed. But my suggestion is to keep it always as default to reduce problems like this and keep original coloring since it's terminal, not the editor itself.

[svipas]

Done in this PR: #205

[adrigm]

I used this theme because this was the only One Dark theme for VS Code that changed the integrate terminal colors.

[svipas]

@adrigm If you're only one who chooses this theme because of integrated terminal coloring you can easily edit your User Settings to include your own coloring for the integrated terminal. But if there are more people like you we should consider about new theme especially with terminal coloring like it's with Vivid.

But it's very hard to color the terminal since everyone uses different coloring and it can introduce a lot of problems and confusions. My suggestion is to not colorize integrated terminal to get the same color in the real terminal and vice versa.

https://code.visualstudio.com/docs/getstarted/theme-color-reference

[svipas]

Okay I tested and without terminal coloring, there are some problems, for e.g. with yellow in the integrated terminal because of our foreground which is not white. So I included the fix in this PR #206. I reverted back @Binaryify terminal colors like it was before. I also improved a little bit green color to not be so bright.

This will be our first steps to perfect integrated terminal coloring.

@adrigm You can use again this theme 😄

[svipas]

@adrigm PR was merged so you will have terminal coloring again, of course not the full, but the critical parts which were not consistent with the theme itself will be fixed.

Thanks, @Binaryify for merging it!

I guess @LukasPolak this issue can be closed?

[LukasPolak]

@Binaryify @svipben I think that issue can be closed