Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting none-1.0 dt #151

Closed
KyungsuKim42 opened this issue Nov 15, 2018 · 3 comments
Closed

Supporting none-1.0 dt #151

KyungsuKim42 opened this issue Nov 15, 2018 · 3 comments

Comments

@KyungsuKim42
Copy link
Contributor

I tried to change the value of dt from 1.0 to 0.1, but it didn't fit in the pipeline with other components. The error I encountered was difference of number of timesteps between encoded input's and network. Since encoded input's number of timesteps is time while network's number of timesteps is time/dt. I was thinking about resolving this issue, but I found that it requires redesigning almost every encoding functions. Any idea about this? Or am I missing something?

Thank you.

@djsaunde
Copy link
Collaborator

Hi @godelicbach,

An easy way to fix this is to create a new Pipeline variable self.sim_time = int(time / dt), and pass this into the encoding functions. Or, we could redesign the encoding functions themselves (which are sorely in need of an update anyway) by having them accept a dt argument as well.

Thoughts?

@djsaunde
Copy link
Collaborator

After a bit more thought, I think it makes more sense to have all encoding functions accept a dt argument. For example, in the poisson encoding, the spike train generation must depend on the simulation time step in order to achieve the correct firing rates.

@djsaunde
Copy link
Collaborator

This has been resolved by #152.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants