Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetImpressionShare is not defined #250

Closed
kamiltiqets opened this issue Jul 11, 2023 · 1 comment
Closed

TargetImpressionShare is not defined #250

kamiltiqets opened this issue Jul 11, 2023 · 1 comment

Comments

@kamiltiqets
Copy link

There's a missing type definition in extensions.py file, causing the following exception:

Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.7/site-packages/bingads/v13/internal/bulk/bulk_object.py", line 107, in convert_to_values
    mapping.convert_to_csv(self, row_values)
  File "/home/airflow/.local/lib/python3.7/site-packages/bingads/v13/internal/bulk/mappings.py", line 112, in convert_to_csv
    self.entity_to_csv(entity, row_values)
  File "/home/airflow/.local/lib/python3.7/site-packages/bingads/v13/internal/extensions.py", line 223, in campaign_biddingscheme_to_csv
    entity_biddingscheme_to_csv(bulk_campaign.campaign, row_values)
  File "/home/airflow/.local/lib/python3.7/site-packages/bingads/v13/internal/extensions.py", line 252, in entity_biddingscheme_to_csv
    row_values[_StringTable.TargetImpressionShare] = TargetImpressionShare(entity.BiddingScheme.TargetImpressionShare)
NameError: name 'TargetImpressionShare' is not defined

You can easily verify it's a bug by checking this file and line:

row_values[_StringTable.TargetImpressionShare] = TargetImpressionShare(entity.BiddingScheme.TargetImpressionShare)

Type TargetImpressionShare is used, but never imported or defined in this file.

@qitia
Copy link
Collaborator

qitia commented Jul 31, 2023

we will fix it in next release.

@qitia qitia closed this as completed Aug 28, 2023
@qitia qitia reopened this Aug 28, 2023
@qitia qitia closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants