Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 2 - Documentations - Readthedocs documentations should be updated #119

Closed
JonnyTran opened this issue Feb 17, 2021 · 4 comments
Closed
Labels
help wanted Extra attention is needed pyopensci-review

Comments

@JonnyTran
Copy link
Owner

JonnyTran commented Feb 17, 2021

  • openOmics version: 0.8.4

Description

@gawbul

Docstrings seem to be available throughout the codebase for all relevant functions, however, I found the documentation on Read the Docs to be lacking in comparison, particularly in providing detail of function parameters that are otherwise available in the docstrings.

There is no link to the contribution guidelines from the main README, which I feel would be beneficial, however contributing guidelines are available in https://github.com/BioMeCIS-Lab/OpenOmics/blob/master/CONTRIBUTING.rst and on Read the Docs.

Just being finicky, I personally would prefer a common format for the README and CONTRIBUTING documents etc. Either both in reStructuredText or both in Markdown. There seems to be an outdated README.rst that could probably be replaced with the current README.md?

@JonnyTran
Copy link
Owner Author

JonnyTran commented Mar 12, 2021

Revamped openomics.readthedocs.io !

@gawbul
Copy link
Collaborator

gawbul commented Apr 22, 2021

Looks awesome 🤩

@gawbul
Copy link
Collaborator

gawbul commented Apr 22, 2021

I did notice that this section of the docs https://openomics.readthedocs.io/en/latest/usage/getting-started.html#creating-a-multi-omics-dataset was missing the following:

from openomics import MultiOmics

Otherwise, the following statement fails:

luad_data = MultiOmics(cohort_name="LUAD", omics_data=[mRNA, mRNA, lncRNA, som, pro])

E.g.:

Traceback (most recent call last):
  File "/Users/stephenmoss/Dropbox/Code/openomics_test.py", line 39, in <module>
    luad_data = MultiOmics(cohort_name="LUAD", omics_data=[mRNA, mRNA, lncRNA, som, pro])
NameError: name 'MultiOmics' is not defined

@JonnyTran
Copy link
Owner Author

Thanks for pointing this out. I will fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed pyopensci-review
Projects
None yet
Development

No branches or pull requests

2 participants