Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installed files refer to the stage directory #674

Closed
yurivict opened this issue Jun 1, 2019 · 1 comment · Fixed by #687
Closed

Installed files refer to the stage directory #674

yurivict opened this issue Jun 1, 2019 · 1 comment · Fixed by #687

Comments

@yurivict
Copy link

yurivict commented Jun 1, 2019

The FreeBSD ports framework complains:

====> Running Q/A tests (stage-qa)
Error: 'bin/uninstall-mirtk' is referring to /usr/ports/graphics/mirtk/work/stage
Error: 'lib/cmake/mirtk/MIRTKInstallManifest.txt' is referring to /usr/ports/graphics/mirtk/work/stage

The stage directory should never be mentioned in the installed files.
@schuhschuh
Copy link
Member

schuhschuh commented Jul 27, 2019 •
edited

When MIRTK is packaged for distribution as binary package, the uninstall-mirtk script and corresponding manifest file should probably not be included, because distributions offer their own package managers that enable deinstallation of the files.

Probably this line should be optional.

@schuhschuh schuhschuh mentioned this issue Aug 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enh: Add BASIS_UNINSTALLER option which is OFF by default schuhschuh/MIRTK
2 participants
@yurivict @schuhschuh