Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't work in IE11 #25

Closed
pdtoloza opened this issue May 14, 2017 · 12 comments
Closed

It doesn't work in IE11 #25

pdtoloza opened this issue May 14, 2017 · 12 comments

Comments

@pdtoloza
Copy link

I think the reason is that the tsconfig has been configured to generate ES6 code.

@ScottBouloutian
Copy link

I couldn't use this package since it does not target ES5 :(

@BioPhoton
Copy link
Owner

What exactly is the issue? I tested it quickly and for me it worked...

@pdtoloza
Copy link
Author

the problem is that the transpiled code has ES6 reserved words, like "class", which are not supported in IE11 (https://kangax.github.io/compat-table/es6/#ie11)

@ScottBouloutian
Copy link

Essentially the same issue on my end, except it was failing for me in PhantomJS, which I am using to run my tests.

@jac1013
Copy link

jac1013 commented Jun 12, 2017

Hey guys, any workaround for this at the moment?

@BioPhoton
Copy link
Owner

Why don't you use the ts files and do the compiling yourself. Just include the ts files in a file and your build task will bundle it with the rest of the app.

@jac1013
Copy link

jac1013 commented Jun 12, 2017

That is the not lazy solution, yes, that's what I'll do, thanks!

@BioPhoton BioPhoton mentioned this issue Jun 12, 2017
3 tasks
@BioPhoton
Copy link
Owner

Hi @jac1013!
Fyi it's on the Roadmap 😉. Currently just no time. Sry!

If you could you do me a favour and create a PR for #19 I would merge it. 😋

@BioPhoton
Copy link
Owner

Hi @jac1013!

Any updates from your side about the PR?

@jac1013
Copy link

jac1013 commented Jun 15, 2017

Hey @BioPhoton, I plan to work on this later (probably this weekend), what do we exactly need here? changing all the TS files in the distribution to be compiled in ES5? Just double checking that we are in the same page.

@BioPhoton
Copy link
Owner

Wow! Sounds great!

I guess if we just upgrade the build tooling. See #19. Everything should be Fine with the next Version.

Thx
Michael!!!

@BioPhoton
Copy link
Owner

Hi all!

I updated the tooling => #19

Could you pleases check if the es5/6 error is still present?

Best
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants