Bugfix/fix return type for get method

[kubadospial]

references this issue: #193

[BioPhoton]

I fount a couple of more typing issues.

See safe-pluck here: https://github.com/BioPhoton/rx-angular/blob/fix-return-type-for-get-method/libs/state/src/lib/core/utils/safe-pluck.ts
and the state (wip) here: https://github.com/BioPhoton/rx-angular/blob/fix-return-type-for-get-method/libs/state/src/lib/rx-state.service.ts

[JakubDospial]

I fount a couple of more typing issues.

See safe-pluck here: https://github.com/BioPhoton/rx-angular/blob/fix-return-type-for-get-method/libs/state/src/lib/core/utils/safe-pluck.ts
and the state (wip) here: https://github.com/BioPhoton/rx-angular/blob/fix-return-type-for-get-method/libs/state/src/lib/rx-state.service.ts

if it's not relevant with this issue please open separate issue and I will handle it on another PR

[BioPhoton]

I @JakubDospial as suggested please take the propper implementation from https://github.com/BioPhoton/rx-angular/tree/fix-return-type-for-get-method.

Also please reuse the safePluck in distinctUntilSomeChanged.ts

[hoebbelsB]

thanks for your great work!
I have adjusted the behavior of safePluck to fit the null undefined conventions of our other internals.

The reason why safePluck is safe is that it raises no error when a corrupt input comes by. This was the most frustrating thing when using the old pluck pipe. You always had to check for null and undefined before you could safely use it.

[hoebbelsB]

hey jakub, together with @Karnaukhov-kh I was reviewing your PR again. We maybe plan to move the safePluck method inside the transformation-helpers. That's why we wanted to make sure it really behaves like all our other internals. When you are fine with those suggestions, please commit them 👍

[BioPhoton]

@hoebbelsB @Karnaukhov-kh

Is this ready for merge?

[hoebbelsB]

ty :)

[hoebbelsB]

@hoebbelsB @Karnaukhov-kh

Is this ready for merge?

@BioPhoton yes from my point of view!

[hoebbelsB]

thanks!