Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please put a warning when covariates are present but not used #6

Open
ne1s0n opened this issue Sep 29, 2021 · 1 comment
Open

Please put a warning when covariates are present but not used #6

ne1s0n opened this issue Sep 29, 2021 · 1 comment

Comments

@ne1s0n
Copy link

ne1s0n commented Sep 29, 2021

The runSingleTraitGwas() function ignores covariates present in the gData object if the "covar" argument is NULL (default).
This is counterintuitive and at this point I had to correct three colleagues that thought the covariates were being used.

The best interface choice imho should be to use by default all the covariates present in the gData. If you want to keep the current behavior at least put a warning (or a message) specifying that covariates are present but not used, and to use the "covar" argument to select what to include in the model.

@BartJanvanRossum
Copy link
Contributor

Thanks for your suggestion. I will discuss this with our internal users to see what their experience is with the "covar" argument and if a change in default behavior is needed.

A warning doesn't harm anyone, so that will definitely be added in the next version of the package.

@ne1s0n ne1s0n closed this as completed Oct 1, 2021
@ne1s0n ne1s0n reopened this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants