Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Saved Sources When Selecting Favorites #2135

Closed
flaccidbagel opened this issue Oct 1, 2020 · 1 comment
Closed

Load Saved Sources When Selecting Favorites #2135

flaccidbagel opened this issue Oct 1, 2020 · 1 comment
Assignees
Milestone

Comments

@flaccidbagel
Copy link

flaccidbagel commented Oct 1, 2020

Is your feature request related to a problem? Please describe

I'm not entirely sure if this is a feature request or a bug report, but when loading a favorited search, the search is performed with the currently selected sources.

For example, if a favorite is saved from a search with only Pixiv enabled, but you then attempt to load that favorite while you have a different source selected, such as Twitter, the newly opened favorites tab attempts to search on Twitter rather than Pixiv. If you're saving favorites from multiple sites, it becomes somewhat cumbersome to access them all.

Describe the solution you'd like

It would be nice if whenever a favorited search is selected, it attempts to load that tab with the sources enabled that it was saved with.

For example, if I favorite "Pikachu" with Pixiv selected as the source, I would like the program to remember which source was selected. Then, even if I have say, Twitter selected as the source currently, if I click "Pikachu" from my favorites on the left sidebar, I'd like it to perform that search with the Pixiv source.

Describe alternatives you've considered

It appears that this kind of behavior is already present to a degree, as I can select the source to use IN the favorites tab itself. However, this view is a bit awkward, and appears to be more for monitoring only new images instead of browsing all of the images that meet the search criteria. It also appears that this has to be manually set for each favorite, instead of it automatically using the sources selected at the time it was favorited.

Additional context

image

In this example image, "pikachu" was saved with Pixiv as the selected source. I also selected Pixiv as the source to use for this search in the favorites tab. However, when I click pikachu from my favorites on the left, it opens a new tab and attempts to search on the currently selected sources, Safebooru and Twitter, instead of Pixiv.

@Bionus
Copy link
Owner

Bionus commented Oct 16, 2020

Indeed, the feature to edit sources for a given favorite was added after the favorites were introduced, and as such were missing this. It makes sense to use the active source as "default" when adding a favorite, as some tags don't make sense on some sources, so they're linked to their original source.

I just pushed the change 👍

@Bionus Bionus self-assigned this Oct 16, 2020
@Bionus Bionus added this to the 7.3.3 milestone Oct 16, 2020
@Bionus Bionus closed this as completed in 351e24a Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants