Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Theming: Get Default Color Values from Terminal #157

Closed
n4n0GH opened this issue Oct 1, 2019 · 3 comments
Closed

Theming: Get Default Color Values from Terminal #157

n4n0GH opened this issue Oct 1, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@n4n0GH
Copy link

n4n0GH commented Oct 1, 2019

What do you want

Cordless should not override the terminal colors with it's own configuration by default, instead it should check for colorschemes and use those as default with possible override by user as an option.

Why

Customizing your terminal is something us autists do and having a terminal application force it's colors can result in fugly results.

Implementation hints

¯\_(ツ)_/¯

(also thank you for making this, it's really comfy <3)

@Bios-Marcel
Copy link
Owner

Yeah, there are some problems regarding that in the underlying terminal library afaik.

Check this out:
rivo/tview#314

It's a good example. Using default will work, but resetting it back to default won't. Maybe there's some way to achieve this anyway, I gotta see,

I don't know whether I can fix this and when. But you can at least apply a workaround if you want to:
https://github.com/Bios-Marcel/cordless/wiki/Themes

@Bios-Marcel Bios-Marcel added the bug Something isn't working label Oct 5, 2019
@n4n0GH
Copy link
Author

n4n0GH commented Oct 5, 2019

Yes, overwriting using the theme.json works but oh boy what a hassle. Anyway thanks for checking it out!

@n4n0GH n4n0GH closed this as completed Oct 5, 2019
@Bios-Marcel
Copy link
Owner

Yeah, it's not good, I know. I also wanted to write a simple tool within cordless for this, so it'd make the stuff a bit easier and show a live preview. But that'd take some time and doesn't have much of a priority for me right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants