Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Allow Video Playback via External Application #320

Closed
Quist0n opened this issue Aug 13, 2020 · 4 comments
Closed

Allow Video Playback via External Application #320

Quist0n opened this issue Aug 13, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@Quist0n
Copy link

Quist0n commented Aug 13, 2020

What do you want

Add support for using an external video player such as mpv or vlc and such, to handle the playback of videos.

Why

Overall, it would expand the realms of what Cordless can do, and bring it closer to the functionality that the official Discord client
has baked in without sacrificing the terminal-oriented goal of the project as well as keeping the performance benefits of not running a traditional window-ed GUI.

Implementation hints

I have tested and found that running mpv or vlc on its own against a Discord link to a video will allow it to play the video, so that alone is possible. Therefore I believe that it would be a similar to how images are currently displayed through Cordless using feh (on linux at least, though Windows implementation I believe could work similarly). A simple matter of calling the program on the link and letting it run.

P.S: This is my first actual feature request that I have made so if I have missed out anything I will edit this post as needed. Thank you for your consideration.

@Quist0n Quist0n changed the title Allow Video Playback Allow Video Playback via External Application Aug 13, 2020
@Bios-Marcel
Copy link
Owner

Basically a dupe of #317

There should probably be a generic file handler where you can have free mappings with a placeholder or so, such as:

"filehandlers": [
  "flv": "vlc -someparam -file $file -something else"
  "mp3": "somemp3player $file"
]

and downloading would be done beforehand, to ensure that applications which don't support streaming will work. On top of that caching could be done as well, in order to save bandwidth 🤷

@Bios-Marcel Bios-Marcel added the enhancement New feature or request label Aug 13, 2020
@Bios-Marcel
Copy link
Owner

Also related: #314

@Bios-Marcel
Copy link
Owner

Closing in favor of #314 as i assume that will solve the needs :)

@Bios-Marcel
Copy link
Owner

Might wanna check out and try this branch: https://github.com/Bios-Marcel/cordless/tree/file_open
Put feedback into #314 please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants