Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Texteditor heighcalculation incorrect #41

Open
1 of 2 tasks
Bios-Marcel opened this issue Feb 10, 2019 · 3 comments
Open
1 of 2 tasks

Texteditor heighcalculation incorrect #41

Bios-Marcel opened this issue Feb 10, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@Bios-Marcel
Copy link
Owner

Bios-Marcel commented Feb 10, 2019

Is your source up to date

  • Yes
  • No

What happened

The texteditor often unnecessarily requests more height.

What did you expect to happen

That more height is only requested if the user actually filled the current line or manually inserts a linebreak.

How do you reproduce this bug

Just type a lot.

How to fix

Correct the line count calculation. This probably needs to be a feature of Bios-Marcel/tview, because that is the only place knowing about the line wrapping.

System information

Key Value
OS Ubuntu-18.10
Architechture x64
@Bios-Marcel Bios-Marcel added bug Something isn't working good first issue Good for newcomers labels Feb 10, 2019
@Bios-Marcel Bios-Marcel changed the title Texteditor requests additional height at hardocded width Texteditor requests additional height at hardocoded width Feb 11, 2019
@Bios-Marcel Bios-Marcel changed the title Texteditor requests additional height at hardocoded width Texteditor heighcalculation incorrect Feb 15, 2019
@avahe-kellenberger
Copy link
Collaborator

I haven't been able to replicate this issue - is it still happening for you? If so, what terminal are you using?

@Bios-Marcel
Copy link
Owner Author

Bios-Marcel commented Jul 12, 2019

Yeah, I can still replicate this, type something like this:

wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww wwwwwwwwwwwwwwwwwwwwwwww

at some point it won't have enough height.

I am using termite (vte based).

@avahe-kellenberger
Copy link
Collaborator

I see, just happened in mine - the very top line gets cut off. Will look into this soon (probably this evening)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants