-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching package dependency #41
Comments
Could we simply replace it with 'ks.test' or provide a bootstrapped ks-test that does not require a deprecated package, e.g. adopting the code from this thread or from this website? Might not be very elegant - but better than being archived! |
'Matching' has become available again, so I am waiting to hear back from CRAN maintainers on whether or not we need to make any further changes. Worst case, I've made a branch 'no_match_depend' which replaces the bootstrapped ks.test with a simple ks.test which can be used in case we need it. Will let you know what CRAN says. |
Sorry I haven't been able to look into this until now. The reason I used the matching package ks test is that it does not assume independence of samples (since the kernels involved in the within individual overlaps will also be involved in the between individual overlaps) and also does not assume continuous distributions (since the overlap values are percentages). I seem to remember there was not a big difference between the bootstrapped KS test and the normal KS test, but it seemed more appropriate. Let's see if matching can still be a solution, if not, I'd at least issue a warning with the result if we use the non bootstrapped ks test? I'll try to think of an alternative way of doing this |
Ok so still not 100% certain (we'll see come Friday) but I BELIEVE the package is not currently at risk of archiving, since the Matching package is again available on CRAN. |
OK so just FYI our package has been taken off CRAN until we pass the checks. I re-submitted it last friday but it came back with a tiny note so I have fixed that and re-submitted today. Hopefully should be back online late this week. |
Ok, we're back online. For now no need to worry about removing the Matching dependency, as that package appears to also be actively maintained. |
As you can see here, the Matching package is not currently available on CRAN. Because the track2KBA::indEffectTest() function uses Matching::ks.boot(), our package is at risk of being archived.
@VirginiaMorera can you think of an alternative method for running this bootstrap that wouldn't require the Matching package?
We have until April 23rd to fix this and pass the CRAN tests or our package will be removed from CRAN.
The text was updated successfully, but these errors were encountered: