Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request enable location crash #83

Closed
kosratdev opened this issue May 18, 2023 · 2 comments
Closed

Request enable location crash #83

kosratdev opened this issue May 18, 2023 · 2 comments

Comments

@kosratdev
Copy link
Contributor

kosratdev commented May 18, 2023

Describe the bug
The second request to enable location will make a crash if the first has been canceled.

To Reproduce
Steps to reproduce the behavior:

  1. Go to device settings and turn off the location.
  2. Open the locus sample app.
  3. Enable resolve location settings.
  4. Start getting location
  5. The app asks to enable location service.
  6. Cancel the request
  7. Press the start button again
  8. Crash 💥

Expected behavior
I'm expecting to request to enable the location again.

Screenshots
Screenshot 2023-05-18 at 16 03 03

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: Emulator
  • OS: Android API 33
  • Browser [e.g. stock browser, safari]
  • Version 4.1.1

Additional context
Add any other context about the problem here.

@kosratdev
Copy link
Contributor Author

Hi @BirjuVachhani, I have fixed this issue in PR #84. Please check it.

@BirjuVachhani
Copy link
Owner

Fixed in v4.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants