Optimize gas fee for deregisterProvingKey in VRFCoordinator contract

[huyhuynh3103]

No description provided.

[martinkersner]

Hello @huyhuynh3103 ,

Thank you for raising the issue! Could you be please more specific where is the exact problem?

We have noticed the same issue in chainlink smart contract and proposed a fix through smartcontractkit/chainlink#8248.

According to our understanding our implementation does not have this problem. We have added a break

orakl/contracts/src/v0.1/VRFCoordinator.sol

Line 171 in 2283521

break;

to save a gas in deregisterProvingKey.

Cheers,
Martin

[huyhuynh3103]

Hello @martinkersner,
I can save gas for deregisterProvingKeyHashes function by caching the length of array to memory, avoiding assigning defaults value for the index variable, and unchecking the overflow of the looping index while increasing its value.
I can not create a new development branch while creating an issue as well as pushing my changes from local branch. So I fork this project and create pull request into its forked repo. Here is pull request: #401.

[martinkersner]

Thank you! Please check my comment at #401