Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethereum] sign transactions #91

Open
2 tasks
florianlenz opened this issue Aug 20, 2018 · 2 comments
Open
2 tasks

[ethereum] sign transactions #91

florianlenz opened this issue Aug 20, 2018 · 2 comments
Assignees
Milestone

Comments

@florianlenz
Copy link
Contributor

Feature / Issue

Geth has an interface for singing transactions - we should change the key manager to implement it. Right now we send the the transaction parameters to pangea were they are signed. We should change it so that we send the transaction params pangea BUT sign them in panthalassa which will be the main difference.

Acceptance criteria

  • tests
  • key manager implement ethereum signing interface

Related to

@florianlenz florianlenz added this to the 1.2.0 milestone Aug 20, 2018
@borjantrajanoski borjantrajanoski self-assigned this Aug 20, 2018
@borjantrajanoski
Copy link
Contributor

Is there any spec describing how the transaction parameters are currently send to Pangea?
From what I've been able to figure out, it looks like it's using the protobuffs located at panthalassa/api/pb

Is our goal to correctly fill the hash field below directly from Panthalassa or do we need to modify protobuffers?

message Response {

    message SendEthereumTransaction {
        uint32 nonce = 1;
        // must be base 10!
        string gasPrice = 2;
        // must be base 10!
        string gasLimit = 3;
        string to = 4;
        // must be base 10!
        string value = 5;
        string data = 6;
        string v = 7;
        string r = 8;
        string s = 9;
        uint32 chainID = 10;
        string from = 11;
        string hash = 12; <== Should this field store the correctly signed transaction? 
    }
    SendEthereumTransaction sendEthereumTransaction = 6;
}

@florianlenz
Copy link
Contributor Author

@kevowevo this should be done at the 29th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants