Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valgrind run to CI #139

Open
afk11 opened this issue Jul 4, 2019 · 1 comment
Open

Add valgrind run to CI #139

afk11 opened this issue Jul 4, 2019 · 1 comment

Comments

@afk11
Copy link
Member

afk11 commented Jul 4, 2019

as mentioned in #131, we should have travis run valgrind tests.

recently I've done some work on this using a php build from source with the following:
./buildconf && ./configure --with-valgrind --with-pcre-valgrind --with-secp256k1 && make -j8

with the projects secp256k1 dir located in ./ext/secp256k1 and then using the following to run valgrind tests: make test TESTS="./ext/secp256k1/tests -m"

ideally we'd be able to run this on multiple php versions - maybe several Docker files in phpqa?

@afk11
Copy link
Member Author

afk11 commented Jul 5, 2019

seems a debug build of php mightn't be necessary (for simply testing for issues anyway), so travis' php should be suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant