Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📱 Revise Daily spending wallet -> Requesting bitcoin page #784

Closed
GBKS opened this issue Apr 25, 2022 · 5 comments · Fixed by #887
Closed

📱 Revise Daily spending wallet -> Requesting bitcoin page #784

GBKS opened this issue Apr 25, 2022 · 5 comments · Fixed by #887
Assignees
Labels
Copy Task is about improving text. Daily spending wallet Referring to the Daily spending wallet reference design section. Design Task is about designing something.

Comments

@GBKS
Copy link
Contributor

GBKS commented Apr 25, 2022

With our recent re-org milestone, various pages were bundled into this new Daily spending wallet reference design. The content now needs to be revised for consistency in general, and more specifically to ensure that the guidelines are focused on a mobile lightning wallet for daily spending.

This issue is for revising the Requesting bitcoin page.

@GBKS GBKS added Copy Task is about improving text. Design Task is about designing something. Daily spending wallet Referring to the Daily spending wallet reference design section. labels Apr 25, 2022
@Bosch-0 Bosch-0 self-assigned this May 1, 2022
@Bosch-0
Copy link
Collaborator

Bosch-0 commented May 1, 2022

Going to address the unified QR toggle in this issue which I'm okay doing: #690

@Bosch-0
Copy link
Collaborator

Bosch-0 commented May 5, 2022

Just another suggestion for this page when using a home screen number pad.

When switching between units (sats <=> fiat) when an amount is already entered the input should be zeroed. This prevents inaccurate conversion calculations and makes it so the amount being sent is exactly what the user wants to send (in sats or fiat terms).

Example with Zeus https://www.figma.com/proto/TqAM4LvuqvY7FBzFoaezJC/%E2%9A%A1-Zeus?page-id=134%3A661&node-id=5583%3A31966&viewport=405%2C48%2C0.2&scaling=scale-down&starting-point-node-id=5583%3A31966

@GBKS
Copy link
Contributor Author

GBKS commented May 5, 2022

I'd use the toggle just to see how much the amount is in "the other currency", so I would not appreciate it getting reset to 0.

@Bosch-0
Copy link
Collaborator

Bosch-0 commented May 6, 2022

You can show the other unit equivalent under the input so you don't have to click the toggle for that

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Jul 8, 2022

I touch on subscriptions in my requesting PR but thinking having a dedicated subscriptions page in daily spending wallet reference design may be needed. There is a lot of UX complexity to them which I felt like was going out of the scope of the requesting page

Comment related to #767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy Task is about improving text. Daily spending wallet Referring to the Daily spending wallet reference design section. Design Task is about designing something.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants