Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for crypto_list to add and increase priority of stablecoins #82

njwedwards opened this issue Mar 19, 2021 · 3 comments
enhancement New feature or request


Copy link

I noticed this after checking my calculation and noticing that I had a large loss that was incurred on BUSD when traded against XRP, however in reality the loss was from XRP which had lost value. This was due to the setup of crypto_list.

I believe that stablecoins should be added as the highest priority coins.

The current setup:

crypto_list: ['BTC', 'ETH', 'XRP', 'LTC', 'BCH', 'USDT']

My new setup (which could be a sensible default):

crypto_list: ['USDT', 'BUSD', 'USDC', 'BTC', 'ETH', 'XRP', 'LTC', 'BCH']

After this change the calculations seem correct with losses and profits being in the right place, with my stablecoin holdings not showing wild losses (or gains), just the change from GBP.

I think it would also be good to add an explanatory note to [] particularly as others may use less well known stablecoins etc.

Copy link

Hi @njwedwards thanks for raising this.

I have another change in the works related to stable coins which will fix this.

The plan is to have a new config option stablecoin_list. These stable coins will use a different method to get the GBP price.

Instead of going via BTC into GBP, they will go via USD to GBP to best avoid the daily price fluctuations of BTC.

The priority order will then be changed to fiat_list + stablecoin_list + crypto_list which will fix your issue.

This change will also fix issue #71.

@nanonano nanonano self-assigned this Mar 19, 2021
@nanonano nanonano added the enhancement New feature or request label Mar 19, 2021
Copy link

Thanks Scott, one step ahead!

Copy link

xrchz commented Jun 22, 2022

I would love to use this not just for stablecoins, but for assets where I don't want to have to convert to BTC first since they have nothing to do with BTC (but do have a price in USD on all/most price sources).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
enhancement New feature or request
None yet

No branches or pull requests

3 participants