Switch to using C FFI types in core (Rust 1.64.0+)
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Rust 1.64.0, the C types we were using in the `libc` crate are now available in `core::ffi`; this commit switches to using `core::ffi`.
Similarly to commit 05ee5fc, the types that we were using in the `libc` crate are available in `core::ffi` as of Rust 1.64.0.
More generic this way.
|
I took a second look at my changes. Still looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Rust 1.64.0 has landed, the C FFI types we need in
n2o4andcfs-sysare available incore::ffion stable Rust.This pull request has the following effects:
libc::c_*tocore::ffi::c_*, removing the need for thelibccrate as a dependencyprintf_wrap::NullStringto any implementer ofAsRef<CStr>(asCStr's available in#[no_std]land now)Resolves #3.