Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation with certain versions of gcc #25

Closed
wants to merge 1 commit into from

Conversation

justinkb
Copy link
Contributor

On FreeBSD at least, with GCC 4.7, par2cmdline fails to compile, complaining about PATH_MAX.

Including <limits.h> fixes this

BlackIkeEagle added a commit that referenced this pull request Mar 20, 2014
This solution is automake based to fix the issue described in #25
My initial thought is if we use the solution of #25 we will have issues
building on windows.

Signed-off-by: BlackEagle <ike.devolder@gmail.com>
@BlackIkeEagle
Copy link
Member

i personally think this could create a problem when building on windows

so i think the following fcbb57a
might be a better solution for this

@justinkb
Copy link
Contributor Author

Works for me, just tested this on my fbsd box. Nice, cheers

pcordes pushed a commit to pcordes/par2-cleanhistory that referenced this pull request May 6, 2015
This solution is automake based to fix the issue described in Parchive#25
My initial thought is if we use the solution of Parchive#25 we will have issues
building on windows.

Signed-off-by: BlackEagle <ike.devolder@gmail.com>
pcordes pushed a commit to pcordes/par2-cleanhistory that referenced this pull request May 6, 2015
resolves Parchive#25

* origin/freebsd_limits:
  FreeBSD gcc compilation fails because of missing limits.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants