Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port HashedString32 #55

Open
MakoEnergy opened this issue Jun 26, 2019 · 2 comments
Open

Port HashedString32 #55

MakoEnergy opened this issue Jun 26, 2019 · 2 comments
Labels
enhancement mezzanine port The code for this exists in the old Mezzanine and should be copied and modified from there.
Milestone

Comments

@MakoEnergy
Copy link
Member

Port over the HashedString32 class and its tests from the monolithic repo.

https://github.com/BlackToppStudios/Mezzanine/blob/master/Mezzanine/src/hashedstring.h
https://github.com/BlackToppStudios/Mezzanine/blob/master/Mezzanine/src/hashedstring.cpp
https://github.com/BlackToppStudios/Mezzanine/blob/master/UnitTests/tests/hashedstringtests.h

This was originally written pre-c++11, prior to the existence of std::hash. This may or may not be worthwhile for us to use, as the actual hashing algorithm is implementation defined (as long as it meets certain standardized criteria). So we should evaluate if we want the the std implementation, interface, or none. In the event we decide to port our own hashing implementation these files should be used:

https://github.com/BlackToppStudios/Mezzanine/blob/master/Mezzanine/src/Internal/murmurhash3.h.cpp
https://github.com/BlackToppStudios/Mezzanine/blob/master/Mezzanine/src/Internal/murmurhash3.cpp

@MakoEnergy MakoEnergy added enhancement mezzanine port The code for this exists in the old Mezzanine and should be copied and modified from there. labels Jun 26, 2019
@MakoEnergy
Copy link
Member Author

MakoEnergy commented Jun 28, 2019

Also, this issue is relevant: BlackToppStudios/Mezzanine#113

Edit: Since we're using C++17 now, HashedStringView?

@Sqeaky Sqeaky added this to the 1.0 milestone Nov 22, 2019
@MakoEnergy
Copy link
Member Author

As of commit c690896 the Murmur hash functions from the monolith repo have been ported, getting one step closer to completing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement mezzanine port The code for this exists in the old Mezzanine and should be copied and modified from there.
Projects
None yet
Development

No branches or pull requests

2 participants