Fix Issue#10 : Handle TNT and Projectiles in Kill Mob Objective #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikaMug
pushed a commit
that referenced
this pull request
Feb 15, 2015
Fix Issue#10 : Handle TNT and Projectiles in Kill Mob Objective
|
Thanks! |
|
Thank YOU! I should've mentioned this in advance, but I think this will break 1.7 backwards compatibility if you're striving for that. I'm not certain, but looking at the code you could probably just change ProjectileSource to Object since we don't really use the interface at all anyway. |
|
I'll look into that at some point in the future. Right now I think it's important that it works for the majority of users. And I'll keep that suggestion in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address issue #10 with regards to projectiles and TNT.
This does not seem to address the cases of punching a mob off of a cliff, into fire/lava, or any of those secondary kills. I'm not sure how to do that.
Tested with splash potions, projectiles, direct damage (via another plugin) and placing and lighting a TNT block.
This also comments out the stacktrace in checkQuester, it gave me a 15GB log file. I'm not sure what's going wrong there, but I opened issue #14 for this.