Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on Null Values #8

Closed
rgant opened this issue Jun 27, 2016 · 1 comment
Closed

Error on Null Values #8

rgant opened this issue Jun 27, 2016 · 1 comment

Comments

@rgant
Copy link
Contributor

rgant commented Jun 27, 2016

Some of the fields in my models have the value of null. This causes an error because null doesn't have a constructor property.

js-data-jsonapi/src/JsonApiSerializer.ts

Line 621 in d67ff61

if (val.constructor === ModelPlaceHolder) {

I think that this:
if (val.constructor === ModelPlaceHolder) {

Needs to change to this:
if (val !== null && val.constructor === ModelPlaceHolder) {
@BlairAllegroTech
Copy link
Owner

Thanks @rgant , i appreciate the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgant @BlairAllegroTech