Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to cover full bounding box on super ultra wide #30

Open
Hezkore opened this issue Feb 15, 2024 · 7 comments
Open

Unable to cover full bounding box on super ultra wide #30

Hezkore opened this issue Feb 15, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Hezkore
Copy link

Hezkore commented Feb 15, 2024

My monitor is 5120 x 1440, so the image is very wide.
I have my bounding box for the desktop capture set to 1920 x 1080 and "Scale to inner bounds".
But when I zoom in it doesn't actually cover the entire bounding box, it only covers what it already renders.

Is there a way to fix this?
I've attached a video demonstrating this, notice the black bars at the top and bottom.

2024-02-15.01-16-26_edit.mp4
@Hezkore
Copy link
Author

Hezkore commented Feb 15, 2024

I'm not exactly sure how the "Set manual source position" option works, but I've modified the code so that it at least makes sense to me.

By changing these lines:

local new_size = {
width = zoom.source_size.width / zoom.zoom_to,
height = zoom.source_size.height / zoom.zoom_to
}

To:

local new_size = {
    width = monitor_override_w / zoom.zoom_to,
    height = monitor_override_h / zoom.zoom_to
}

I get the expected result when setting "Monitor Width" to 5120 and "Monitor Height" to 1440, then "Width" to 1920 and "Height" to 1080 in the "Set manual source position" menu.

I've attached a video demonstrating this.

2024-02-15.01-58-44_edit.mp4

@BlankSourceCode
Copy link
Owner

@Hezkore That's a great workaround. I suspect the change may break some scenarios depending on the sort of zoom source and/or crop values it might have, but I'm glad you got it working for your case.

To be honest, there are so many different sizes and positions in the script now that even I get confused about what they all do. I probably need to overhaul them at some point.

Thanks for posting this, I'm going to point some others at it to see if the same workaround fixes their issue.

@ibrah3m
Copy link

ibrah3m commented Feb 19, 2024

worked

@estebandelpino
Copy link

Worked for me too! Thank you for sharing :)

@chriszuko
Copy link

I might cry. Finally a zoom script that works. Thank you so much for posting this workaround for ultrawide.

@MajorWookie
Copy link

I think I have a similar issue. My monitor size is 3840x2160, but I have it scaled down to 1920x1080 for readability in my settings. My zoom doesn't quite zoom in on the cursor, nor does it follow it. Here is a gif

2024-05-09_17-53-34 (2)

transform setting
2024-05-09_17-57-25

Script setting
2024-05-09_17-57-10

@MajorWookie
Copy link

Update: I was able to resolve my issue.

  1. Checked my Video setting. Made the base (Canvas) Resolution the same as my monitor resolution.
2024-05-09_23-04-17
  1. Set manual source potion to the below
2024-05-09_23-07-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants