Expose brush dependencies, simplify BrushBuilder #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make important dependencies accessible for the end user. Like FontRef for example, so a brush can be stored in a struct.
|
What a coincidence! I just published v0.5.0 in which I worked on simmilar issues. Can you try to update your repo and commit the same changes and I'll merge. |
|
Ok I resolved conflicts, and added a type for readability. One tip I can give you is to maybe try to reduce generic usage, it can often make the code hard to read and is not always necessary. I haven't really looked at your code in debt, but for example the depth_stencil builder, I think you can simplify if its passed as a parameter in the same build function. |
|
Thanks for the tip! I'll try to simplify things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make important dependencies accessible for the end user. Like FontRef
for example, so a brush can be stored in a struct.
In my project I have a state struct so I can split a lot of the render code, but I can't use your library because dependencies are private. Anyway keep up the good work.