Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix CC/CXX variables in CI #1576

Merged
merged 5 commits into from Jul 2, 2021

Conversation

ajschmidt8
Copy link
Contributor

@ajschmidt8 ajschmidt8 commented Jun 29, 2021

This PR adds CC, CXX, and CUDAHOSTCXX entries to the build.script_env section of the conda recipe, so that those environment variables get passed through the build.sh script and ultimately to CMake. This enables CMake to use the correct versions of gcc and g++ when compiling.

Additionally, it includes some fixes for the upstream cudf changes in rapidsai/cudf#8142

@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@ajschmidt8 ajschmidt8 changed the title Fix CC/CXX vars in CI Fix CC/CXX variables in CI Jun 29, 2021
@ajschmidt8
Copy link
Contributor Author

ajschmidt8 commented Jun 29, 2021

@wmalpica, @felipeblazing, looks like the failures here are unrelated to this PR. You should notice in the CI logs here that CMake is now using gcc 9 (instead of gcc 4 as shown in the logs in #1574 for example) which is good.

@ajschmidt8
Copy link
Contributor Author

looks like the error in the image below (log link) could be related to rapidsai/cudf#8142

image

@ajschmidt8
Copy link
Contributor Author

pushed some fixes in 1b2ba51

@ajschmidt8
Copy link
Contributor Author

ajschmidt8 commented Jun 29, 2021

the latest commit seemed to fix some of the build errors, but not all of them. continuing to look into this locally. the last outstanding error messages are these (log link):

image

@ajschmidt8
Copy link
Contributor Author

rerun tests

3 similar comments
@trxcllnt
Copy link
Collaborator

rerun tests

@jakirkham
Copy link

rerun tests

@Christian8491
Copy link
Contributor

rerun tests

@Christian8491
Copy link
Contributor

@ajschmidt8 I've found out the issue (at least for the concatSuite test) related to these last gpuci-jobs failures. Could you provide me permission to push into your own fork ? Or Do you prefer i share with you the delta.patch so you can push these changes from your side ?

@ajschmidt8
Copy link
Contributor Author

@ajschmidt8 I've found out the issue (at least for the concatSuite test) related to these last gpuci-jobs failures. Could you provide me permission to push into your own fork ? Or Do you prefer i share with you the delta.patch so you can push these changes from your side ?

@Christian8491, I do have the box selected to allow edits from maintainers, so you should be able to push. But if you want to share the patch with me, that's fine too! Whatever works.

@jakirkham
Copy link

Thanks for helping out here Christian! 😄

While CI is running, do you or others have thoughts on the changes AJ included here?

@Christian8491
Copy link
Contributor

Christian8491 commented Jul 1, 2021

@romulo-auccapuclla @mario21ic do you guys have some comments/thoughts about this PR ?

@Christian8491
Copy link
Contributor

rerun tests

1 similar comment
@Christian8491
Copy link
Contributor

rerun tests

@Christian8491 Christian8491 changed the title Fix CC/CXX variables in CI [REVIEW] Fix CC/CXX variables in CI Jul 1, 2021
@felipeblazing felipeblazing merged commit 8b3b096 into BlazingDB:branch-21.08 Jul 2, 2021
@ajschmidt8 ajschmidt8 deleted the ci-fix branch July 2, 2021 13:58
@jakirkham
Copy link

Thanks all! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants