New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix CC
/CXX
variables in CI
#1576
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
@wmalpica, @felipeblazing, looks like the failures here are unrelated to this PR. You should notice in the CI logs here that CMake is now using gcc 9 (instead of gcc 4 as shown in the logs in #1574 for example) which is good. |
looks like the error in the image below (log link) could be related to rapidsai/cudf#8142 |
pushed some fixes in 1b2ba51 |
the latest commit seemed to fix some of the build errors, but not all of them. continuing to look into this locally. the last outstanding error messages are these (log link): |
rerun tests |
3 similar comments
rerun tests |
rerun tests |
rerun tests |
@ajschmidt8 I've found out the issue (at least for the |
@Christian8491, I do have the box selected to allow edits from maintainers, so you should be able to push. But if you want to share the patch with me, that's fine too! Whatever works. |
Thanks for helping out here Christian! 😄 While CI is running, do you or others have thoughts on the changes AJ included here? |
@romulo-auccapuclla @mario21ic do you guys have some comments/thoughts about this PR ? |
rerun tests |
1 similar comment
rerun tests |
CC
/CXX
variables in CICC
/CXX
variables in CI
Thanks all! 😀 |
This PR adds
CC
,CXX
, andCUDAHOSTCXX
entries to thebuild.script_env
section of theconda
recipe, so that those environment variables get passed through thebuild.sh
script and ultimately to CMake. This enables CMake to use the correct versions ofgcc
andg++
when compiling.Additionally, it includes some fixes for the upstream cudf changes in rapidsai/cudf#8142