Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid HTML markup in samples #128

Closed
c0g1t8 opened this issue Mar 18, 2020 · 2 comments
Closed

Valid HTML markup in samples #128

c0g1t8 opened this issue Mar 18, 2020 · 2 comments
Labels
Bug Something isn't working Good First Issue Good for newcomers Resolved: Completed The issue has been resolved Up For Grabs This issue is available to anyone that wants to help

Comments

@c0g1t8
Copy link
Contributor

c0g1t8 commented Mar 18, 2020

Describe the bug
The HTML markup in the samples don't generate valid HTML. VS2019 16.5.0 flags it in Intellisense.

To Reproduce
For example, in index.razor
image

Expected behavior

The first p tag should be a div.

image

Screenshots
See above

Hosting Model (is this issue happening with a certain hosting model?):
In both server-side and client-side.

Additional context
N?A
@c0g1t8 c0g1t8 added Bug Something isn't working Triage Issue needs to be triaged labels Mar 18, 2020
@chrissainty
Copy link
Member

Thanks for raising this @c0g1t8. It was a known hack I did to get some padding to the bottom of the cards. I meant to fix it before I merged but I forgot.

Happy to take PRs on this one.

@c0g1t8
Copy link
Contributor Author

c0g1t8 commented Mar 18, 2020 •
edited

I'll put up a PR in an hour :)

@chrissainty chrissainty added Good First Issue Good for newcomers Up For Grabs This issue is available to anyone that wants to help and removed Triage Issue needs to be triaged labels Mar 18, 2020
@c0g1t8 c0g1t8 mentioned this issue Mar 18, 2020
Merged
@chrissainty chrissainty added the Resolved: Completed The issue has been resolved label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Good First Issue Good for newcomers Resolved: Completed The issue has been resolved Up For Grabs This issue is available to anyone that wants to help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrissainty @c0g1t8