-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: footnotes? #34
Comments
Sure - that would help solve a lot of one-off things for agencies. How about calling it note_id So an example would look like: note_id: 1 Please let me know what you think of the proposed field names and if this would be flexible enough to accommodate all possible scenarios. |
Just checking in on this - does my proposal above sound like it would be flexible enough to cover all scenarios you would want notes for? |
Thank you for checking on this. To further brainstorm, here are some ideas & questions. 1: Do we think it would be useful to provide notes that aren't tied to a particular timetable? e.g. A note that is attached to a stop for all timetables? 2: I think it will be useful for notes to have multiple references (e.g. applies to many trips or stops). So, I suggest that we add a timetable_notes_references.txt with fields note_id, stop_id, timetable_id, trip_id, route_id, stop_sequence. If a record references just to stop_id, then it applies for all uses of that stop. But if the reference is to stop_id and timetable_id, then it applies to the stop_id only for that timetable_id, etc. And, multiple rows can reference the same note_id. Multiple rows are not combinatory in their targeting. 3: Default numbering scheme. In cases where a symbol is not provided, should the software automatically generate letters and/or numbers? I did some looking on the web for examples:
|
BTW, this isn't urgent for @trilliumtransit needs right now. But, definitely something we would use in the future. Just putting these comments in here to start considering the feature. |
Here is an updated proposal for two additional non-standard GTFS files:
example note_id: 1
examples note_id: 1 note_id: 2 note_id: 3 note_id: 4 note_id: 5 note_id: 6
|
I have a working version of GTFS-to-HTML with footnote support on this branch: https://github.com/BlinkTagInc/gtfs-to-html/tree/feature/timetable-notes. I'm very interested in your feedback. An example of the output is here: https://gtfs-to-html-notes-demo.vercel.app/20200913-20201212/17.html The The first timetable on this page has examples of several types of notes:
A few observations and questions:
|
I feel it should be an option in |
@brodyFlannigan @antrim I'd like to know if there are agencies that currently have notes that apply to entire trips or entire stops where they apply a symbol to each timepoint in a timetable. I don't think I've ever seen this, so maybe it is not a needed config option and it should not be "noisy" at all. There are a few ways users of GTFS-to-HTML could deal with the "noisy" issue to notes that apply to entire trips or entire stops.
|
@brendannee I think the third option (field in GTFS) is the best option for sure. I think |
Doesn't seem ideal but also doesn't seem terrible. If it matters a lot, users could manually assign notes.
My initial reaction is that GTFS-to-HTML should produce less "noisy" timetables by default. Take that as just an initial reaction. I don't know that I've seen notes carried all the way through columns or rows like that on timetables. Want me to ask for opinions and/or examples from Trillium's website team? Alternative/complementary idea: Adding style classes for notes -- e.g.
Awesome! Also, I love the example footnotes that you've noted. One other thought: Anchor links for the notes would be helpful. This might be especially useful for screenreader users. Example: https://trimet.org/schedules/w/t1090_1.htm |
+1 on that for sure. |
I pushed an update based on all of your comments. Latest code on branch branch: https://github.com/BlinkTagInc/gtfs-to-html/tree/feature/timetable-notes Updated example of the output is here: https://gtfs-to-html-notes-demo.vercel.app/20200913-20201212/17.html The timetable_notes.txt and timetable_notes_references.txt files used to generate this are attached. Here is what has changed:
Please send me any additional feedback or adjustments you can think of, no matter how minor. What do you think of the field name The next step will be to merge into master and document the feature. |
@brendannee Awesome 🎉 |
I just merged this in to GTFS-to-HTML version 1.3.0. I added documentation about the new feature: https://gtfstohtml.com/docs/timetable-notes All feedback is appreciated, including ideas on how to better communicate this complex feature in the documentation. Let me know when you start using this with an agency. |
Should we use a timetable_notes.txt file that allows referencing specific timetables, stops, and trips to add footnotes on a timetable?
(Updated: notes.txt -> timetable_notes.txt)
The text was updated successfully, but these errors were encountered: