Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Support for Message Headers #414

Closed
olib963 opened this issue May 8, 2018 · 10 comments
Closed

Feature Request - Support for Message Headers #414

olib963 opened this issue May 8, 2018 · 10 comments

Comments

@olib963
Copy link

olib963 commented May 8, 2018

The underlying library has support for kafka message headers: confluentinc/librdkafka#1480.

It would be nice if you could expose the headers to the node library for both consumers and producers. We are looking at using them to store event metadata which we can use to debug issues in the case where our avro messages cannot be deserialised properly.

Thank you.

@webmakersteve
Copy link
Contributor

It is definitely something I want to add. I can't tell when I will have time right now to dedicate to it because of how my time at the office has had to be spent, but it is on my radar.

Hopefully I will have some time soon but will also be very, very happy to take a contribution for this.

@alexander-alvarez
Copy link
Contributor

@webmakersteve what's necessary to make this happen? I could try to take a look at it, but the codebase is pretty foreign to me

@webmakersteve
Copy link
Contributor

Looks like message headers are not supported in C++ yet, and the underlying bindings use the C++ version of librdkafka.

@pcjtse
Copy link

pcjtse commented Nov 22, 2018

It looks like the C++ library has a PR added support for headers 7 days ago:

confluentinc/librdkafka#2109

confluentinc/librdkafka#1959

@Fr8Traindb
Copy link

Please! This would be a great feature!

@davidtrihy
Copy link
Contributor

I have this PR open #478 needs a few changes once the librdkafka changes are merged but it should follow it mostly.

@davidtrihy
Copy link
Contributor

Updates to the PR have been made with the new merged changes

@cfinkenstadt
Copy link

👍

@iradul
Copy link
Collaborator

iradul commented Jun 14, 2020

This is resolved with 6065784

@iradul iradul closed this as completed Jun 14, 2020
@raman20
Copy link

raman20 commented Feb 16, 2023

Still not getting headers in message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants