Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-rdkafka cannot be installed on windows 10 #591

Closed
fungiboletus opened this issue Mar 27, 2019 · 6 comments
Closed

node-rdkafka cannot be installed on windows 10 #591

fungiboletus opened this issue Mar 27, 2019 · 6 comments
Labels
stale Stale issues

Comments

@fungiboletus
Copy link

fungiboletus commented Mar 27, 2019

Environment Information

  • OS: Windows 10
  • Node Version: 10.14.0
  • NPM Version: 6.1.0
  • C++ Toolchain: Visual Studio
  • node-rdkafka version: 2.6.1

Steps to Reproduce

npm install node-rdkafka

node_modules\nan\nan.h(1674): note: see declaration of 'Nan::Callback::Call' (compiling source file ..\src\connection.cc)
..\src\callbacks.cc(275): error C2589: '(': illegal token on right side of '::' [stuff\node_modules\node-rdkafka\build\node-librdkafka.vcxp
roj]
..\src\callbacks.cc(275): error C2059: syntax error: '::' [stuff\node_modules\node-rdkafka\build\node-librdkafka.vcxproj]

Additional context

It's a bit sad.

@fungiboletus
Copy link
Author

It's similar to #487 (which is closed but not fixed) with a different error.

@terebentina
Copy link
Contributor

@fungiboletus I don't think it's similar to that other issue. For the issue you're having see my PR here: #585 . It's a really quick fix.

@jomaleda
Copy link

Do we have any update on this issue? I have problems with version 2.6.1 of node-rdkafka on Windows 10 too.

@kowalej-925
Copy link

Same issue over here. I also get a bunch of compilation errors with the new 2.7.0 version. 2.5.1 worked fine.

@stale
Copy link

stale bot commented Sep 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issues label Sep 5, 2019
@iradul
Copy link
Collaborator

iradul commented Sep 5, 2019

2.7.1 installs fine on Windows. Please reopen if you're still having issues.

@iradul iradul closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants