[FIX] Running Complete stage even on Exception catch. (#1186)

dancryer · Apr 27, 2016 · db93f55 · db93f55
1 parent 49db1a2
commit db93f55
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/PHPCI/Builder.php b/PHPCI/Builder.php
@@ -213,8 +213,6 @@ public function execute()
                 $this->build->setStatus(Build::STATUS_FAILED);
             }
 
-            // Complete stage plugins are always run
-            $this->pluginExecutor->executePlugins($this->config, 'complete');
 
             if ($success) {
                 $this->pluginExecutor->executePlugins($this->config, 'success');
@@ -236,6 +234,9 @@ public function execute()
         } catch (\Exception $ex) {
             $this->build->setStatus(Build::STATUS_FAILED);
             $this->buildLogger->logFailure(Lang::get('exception') . $ex->getMessage());
+        }finally{
+            // Complete stage plugins are always run
+            $this->pluginExecutor->executePlugins($this->config, 'complete');
         }