adding a setting to display branch names in Dashboard #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpcibot
reviewed
Feb 5, 2017
| /** | ||
| * Save basic settings. | ||
| */ | ||
| public function latest_builds() |
There was a problem hiding this comment.
PHPCS: Method name "SettingsController::latest_builds" is not in camel caps format
phpcibot
reviewed
Feb 5, 2017
| protected function testDepends($line) { | ||
| /** | ||
| * | ||
| * @param string $line |
There was a problem hiding this comment.
PHPCS: Whitespace found at end of line
|
Hi, In our project we are building several branches at a time and we can't easily tell from Latest Builds panel which branch a build was run on. So I've added an option in Admin Settings so users can choose to display branches names in Latest Builds panel. If enabled then the branch name will appear between brackets, see attached image. I also went ahead and fixed formatting and docblock in TapParser.php so build should be at green again. Thanks for reviewing my PR. |
dancryer
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Type: bug fix | new plugin | new feature | refactor | cosmetic
Link to Intent to Implement:
Link to Bug:
This pull request affects the following areas:
In raising this pull request, I confirm the following (please check boxes):
Detailed description of change: