Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The constant keyword is being used in functions, this will be deprecated at the next breaking release #7

Closed
matt-lough opened this issue Nov 13, 2017 · 2 comments

Comments

@matt-lough
Copy link

constant should not be used for functions, it is going to be invalid at the next breaking release of solidity. (ethereum/solidity#992)

Some of your functions have already been changed to view or pure but this is no consistent.

More info: https://ethereum.stackexchange.com/questions/25200/solidity-what-is-the-difference-between-view-and-constant

@thesved
Copy link

thesved commented Nov 17, 2017

thesved@641e021

I left the wallet untouched, since it is a well-tested consensys multisig wallet, which will hold all the contributions, and I don't feel comfortable to change it.

@OperationNine
Copy link

Yes this is understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants