Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a context-switching form of each is deprecated #13

Merged
merged 1 commit into from
Mar 6, 2015

Conversation

lolmaus
Copy link
Contributor

@lolmaus lolmaus commented Mar 6, 2015

Getting rid of this warning:

DEPRECATION: Using the context switching form of {{each}} is deprecated. Please use the keyword form ({{#each foo in bar}}) instead. See http://emberjs.com/guides/deprecations/#toc_more-consistent-handlebars-scope for more details.

@lolmaus
Copy link
Contributor Author

lolmaus commented Mar 6, 2015

I believe this also resolves a freeze and a Synchronous AJAX request warning that have been poisoning every page refresh since i started using ember-notifications. These two issues seem to have been caused by passing a different this into {{notification-message notification=this}}.

ynnoj pushed a commit that referenced this pull request Mar 6, 2015
Using a context-switching form of each is deprecated
@ynnoj ynnoj merged commit 0bb28d3 into mansona:master Mar 6, 2015
lolmaus added a commit to lolmaus/ember-cli-notifications that referenced this pull request Mar 7, 2015
I'm sorry, that just wasn't right.
ynnoj pushed a commit that referenced this pull request Mar 7, 2015
@ynnoj ynnoj mentioned this pull request Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants