Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Silently catching numexpr errors and changing vm can be confusing #312

Closed
FrancescAlted opened this issue Jun 30, 2016 · 2 comments
Closed

Comments

@FrancescAlted
Copy link
Member

There is an example of that in: pydata/numexpr#150 (comment)

Perhaps a better solution would be to raise an error in case the "numexpr" vm cannot handle an expression and inform the user to use other virtual machine ("python" or "dask"). Opinions?

@thequackdaddy
Copy link
Contributor

What about a warning instead? An outright error seems extreme to me.

@FrancescAlted
Copy link
Member Author

Yes, I was also thinking that a warning would perhaps be the right thing to do. Implemented that in 382c969.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants