Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blosc 1.10 fails to build from source when installed from pip (e.g. on Python 3.6) #239

Closed
itamarst opened this issue Dec 23, 2020 · 3 comments

Comments

@itamarst
Copy link

$ pip install --no-binary :all: blosc 
Collecting blosc
  Downloading blosc-1.10.0.tar.gz (845 kB)
     |████████████████████████████████| 845 kB 4.3 MB/s 
    ERROR: Command errored out with exit status 1:
     command: /tmp/venv/bin/python3.8 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-ed60eri2/blosc/setup.py'"'"'; __file__='"'"'/tmp/pip-install-ed60eri2/blosc/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-97mman7p
         cwd: /tmp/pip-install-ed60eri2/blosc/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-ed60eri2/blosc/setup.py", line 18, in <module>
        from skbuild import setup
    ModuleNotFoundError: No module named 'skbuild'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 20.2.2; however, version 20.3.3 is available.
You should consider upgrading via the '/tmp/venv/bin/python3.8 -m pip install --upgrade pip' command.

The problem is that the way pip figures out the build dependencies is by importing setup.py... but setup.py import scikit-build, thus blowing up before pip can figure out that it needs scikit-build installed.

(I hit this because my install for some reason didn't find the macOS binary wheel, so it fell back to tarball build, not sure why that happened.)

@itamarst
Copy link
Author

Ah, the reason I hit source build is because I installed on Python 3.6, and Python 3.6 doesn't have a binary wheel available. I updated the title.

@itamarst itamarst changed the title Blosc 1.10 fails to build from source when installed from pip Blosc 1.10 fails to build from source when installed from pip (e.g. on Python 3.6) Dec 23, 2020
@FrancescAlted
Copy link
Member

Thanks for bringing this to our attention. This should have been fixed in the new 1.10.1 release.

@itamarst
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants