Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mekanism's tank is not treated as a "bucket" when completing the crafting of treated wood #4449

Closed
Algester opened this issue Nov 15, 2020 · 4 comments · Fixed by #4474
Closed

Comments

@Algester
Copy link

Description of the issue:

mekanism's tank is not being treated as a returned empty bucket on making treated wood with Creosote Oil, I'll relay this info on Mekanism's git if someone thinks this is on mekanism's end

Versions & Modlist

IE: 1.16.3-4.1.1-127
Forge: 34.1.42
Mekanism: 1.16.4-10.0.17.444

@Algester Algester changed the title Mekanism's Mekanism's tank is not treated as a "bucket" when completing the crafting of treated wood Nov 15, 2020
@BluSunrize
Copy link
Owner

As far as I can tell, Mekanism's tank items do not implement getContainerItem.

https://github.com/mekanism/Mekanism/blob/1.16.x/src/main/java/mekanism/common/item/block/machine/ItemBlockFluidTank.java

They should totally do that, and reduce their stored fluid by BUCKET_VOLUME. Report to Mekanism please.

@NielsPilgaard
Copy link

NielsPilgaard commented Nov 30, 2020

This issue was closed without a solution on the Mekanism issue tracker, could you perhaps have another look?
Or perhaps block the Tank from Mekanism from being used at all for your fluid recipes? Having high tier tanks full of creosote voided isn't a great user experience :)

@BluSunrize
Copy link
Owner

Yeah, I'm aware that Mekanism has declared this not their problem. We'll fix this at some point, probably. Just use a bucket for now.

@BluSunrize BluSunrize reopened this Nov 30, 2020
@NielsPilgaard
Copy link

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants