Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better error / warning logging #640

Closed
ohm314 opened this issue Nov 7, 2022 · 1 comment
Closed

Implement better error / warning logging #640

ohm314 opened this issue Nov 7, 2022 · 1 comment

Comments

@ohm314
Copy link
Collaborator

ohm314 commented Nov 7, 2022

Currently we mostly use std::cerr and Exceptions for reporting warnings and errors. This is not very flexible and can sometimes be quite inefficient (e.g. log one message per dataset might create an avalanche of messages for large HDF5 files).

It would be nice to replace this ad-hoc way of reporting things with a proper system. We could use a third-party logger library, or write a simple logging facility / manager into HighFive.

Just quickly considering this I think we need from the logger different log levels, follow-up action (e.g. automatically fail on some log levels), integration with exception handling and singleton logs (or suppression of log messages beyond a given count.

@1uc
Copy link
Collaborator

1uc commented Mar 17, 2023

Closed via #690

@1uc 1uc closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants